doc: mark settings as optional and add callback #26894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The settings are currently not required and the callback was not documented so far. Refs: nodejs#26811
nodejs-github-bot
added
doc
jasnell
approved these changes
Mar 25, 2019
BridgeAR
added
the
author ready
lpinca
approved these changes
Mar 25, 2019
4 tasks
|
Landed in fd992e6 🎉 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 27, 2019
The settings are currently not required and the callback was not documented so far. Refs: nodejs#26811 PR-URL: nodejs#26894 Refs: nodejs#26811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
The settings are currently not required and the callback was not documented so far. Refs: nodejs#26811 PR-URL: nodejs#26894 Refs: nodejs#26811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
The settings are currently not required and the callback was not documented so far. Refs: #26811 PR-URL: #26894 Refs: #26811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
The settings are currently not required and the callback was not documented so far. Refs: #26811 PR-URL: #26894 Refs: #26811 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings are currently not required and the callback was not
documented so far.
This is an alternative to #26811.
Refs: #26811
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes